Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example of a single checkbox to use the new style #394

Merged
merged 2 commits into from
Feb 20, 2017

Conversation

gemmaleigh
Copy link
Contributor

@gemmaleigh gemmaleigh commented Jan 21, 2017

What problem does the pull request solve?

This fixes #335.

What does it do?

  • Rename the snippet
  • Updates the example to use a custom checkbox
  • Remove the text about large hit areas, as this is contradictory

Screenshots (if appropriate):

Before:

before

After:

after

What type of change is it?
  • Bug fix (non-breaking change which fixes an issue)

- Rename the snippet
- Remove the text about large hit areas, as this is contradictory
@robinwhittleton
Copy link
Contributor

I guess we want to be using a large checkbox. Was there any reason the old version was kept as a small one?

@robinwhittleton
Copy link
Contributor

There’s also .form-checkbox and .form-radio styles left in the Sass that appear to be unused. We should remove this as part of this PR.

The styles for custom radio buttons and checkboxes should be used
instead.

These can be found in forms/_form-block-labels.scss
@gemmaleigh
Copy link
Contributor Author

@robinwhittleton I removed those additional styles, this should be good to go.

Copy link
Contributor

@robinwhittleton robinwhittleton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@robinwhittleton robinwhittleton merged commit f1a8df7 into master Feb 20, 2017
@robinwhittleton robinwhittleton deleted the fix-335-update-checkbox-example branch February 20, 2017 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants